Add inout variant of groupedReduce
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the stdlib's `reduce`, the `groupedReduce` can provide an `inout` variant for improved efficiency when the group type has copy-on-write semantics (like `Array` or `Dictionary`). ## Changes - Create new `groupedReduce(into:combine:groupBy)` variant with an `inout` combine closure.
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 94.82% 94.84% +0.01%
==========================================
Files 97 97
Lines 3190 3198 +8
==========================================
+ Hits 3025 3033 +8
Misses 165 165
Continue to review full report at Codecov.
|
literallysofia
approved these changes
Oct 2, 2020
nqtavares
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Similar to the stdlib's
reduce, thegroupedReducecan provide aninoutvariant for improved efficiency when the group type hascopy-on-write semantics (like
ArrayorDictionary).Description
groupedReduce(into:combine:groupBy)variant with aninoutcombine closure.